From: Marco Trevisan (Treviño) <mail@3v1n0.net>
Date: Fri, 21 Oct 2022 17:09:09 +0000 (+0200)
Subject: gdm/util: Early initialize all internal properties
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~281^2~1^2~104
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=f1c0f65075b839b59e082d1cc060f9bc80ac8574;p=gnome-shell.git

gdm/util: Early initialize all internal properties

These may be used later by methods called by constructors, so ensure
that they're all defined early.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2267>
---

diff --git a/js/gdm/util.js b/js/gdm/util.js
index 89ad54497..84eb1315a 100644
--- a/js/gdm/util.js
+++ b/js/gdm/util.js
@@ -103,10 +103,22 @@ export class ShellUserVerifier extends Signals.EventEmitter {
         this._reauthOnly = params.reauthenticationOnly;
 
         this._client = client;
+        this._cancellable = null;
 
         this._defaultService = null;
         this._preemptingService = null;
 
+        this._messageQueue = [];
+        this._messageQueueTimeoutId = 0;
+
+        this._failCounter = 0;
+        this._unavailableServices = new Set();
+
+        this._credentialManagers = {};
+
+        this.reauthenticating = false;
+        this.smartcardDetected = false;
+
         this._settings = new Gio.Settings({schema_id: LOGIN_SCREEN_SCHEMA});
         this._settings.connect('changed',
             this._updateDefaultService.bind(this));
@@ -131,15 +143,6 @@ export class ShellUserVerifier extends Signals.EventEmitter {
             'smartcard-inserted', this._checkForSmartcard.bind(this),
             'smartcard-removed', this._checkForSmartcard.bind(this), this);
 
-        this._messageQueue = [];
-        this._messageQueueTimeoutId = 0;
-        this.reauthenticating = false;
-
-        this._failCounter = 0;
-        this._unavailableServices = new Set();
-
-        this._credentialManagers = {};
-
         this.addCredentialManager(OVirt.SERVICE_NAME, OVirt.getOVirtCredentialsManager());
         this.addCredentialManager(Vmware.SERVICE_NAME, Vmware.getVmwareCredentialsManager());
     }